Working directory default value

[pifopi]

Hello !

Thank you again for your great work, your plugin is amazing ;)

I have an issue with the Working directory. It may be linked to : https://github.com/csoltenborn/GoogleTestAdapter/issues/188 But this time, it is not during the test discovery but the test execution.

If I specify $(ExecutableDir) in the working directory field, it works, otherwise, it crash with these error message : [25/06/2018 15:36:46 Error] 15:36:46.995 - ERROR: Could not create process. Command: 'D:\Perforce\tgt_silexnet_dev_090118\extern\silexnet\bin\win64\functionaltestscontroller_engine_win64_2015_d.exe', parameters: '--gtest_output="xml:C:\Users\gdottel\AppData\Local\Temp\tmp3660.tmp" --gtest_catch_exceptions=1 --gtest_break_on_failure=1 --gtest_filter=D_4Player/NetAuthority.SimpleLockPeerID/0:D_8Player/NetAuthority.SimpleLockPeerID/0:D_2Player/NetAuthority.SimpleLockPeerID/0:D_3Player/NetAuthority.SimpleLockPeerID/0 --debug_peers', working dir: '$(ExecutableDir)' (267: Nom de répertoire non valide)

"Nom de répertoire non valide" means that the directory name is not valid. It seems that it search $(ExecutableDir) for real whereas it should be replaced with the executable directory :)

[csoltenborn]

Thanks for your kind words, and of course the bug report :-)

I have already fixed the issue - if you want to give it a quick try, go for this version.

[pifopi]

Thanks ! I will try this tommorow morning :-)

[csoltenborn]

Sounds good! Please let me know if it works (not that you wouldn't anyways :-) ) - I would like to release the bugfix this evening...

[pifopi]

It works fine for me ! :) I tested empty string, full path and $(ExecutableDir). Everything worked for me ;)

[csoltenborn]

Sweet, thanks!