csoltenborn / GoogleTestAdapter

Visual studio extension that adds support for the C++ testing framework Google Test.
Other
142 stars 101 forks source link

Fix bug where a "my_class const" type would be shown as "my_const". #236

Closed frboyer closed 6 years ago

frboyer commented 6 years ago

As my first pull request on this project, this is a small non critical bug fix. When using type parameterized tests, if the type name ends with "class" or "struct" and is followed by a space (for example a "my_class const"), the type name was incorrectly modified in the DisplayName. I changed the simple replace by a regex replace and modified the test to verify this case.

codecov[bot] commented 6 years ago

Codecov Report

Merging #236 into master will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   74.09%   74.09%   -0.01%     
==========================================
  Files          94       94              
  Lines        3575     3574       -1     
  Branches      523      523              
==========================================
- Hits         2649     2648       -1     
  Misses        742      742              
  Partials      184      184
Flag Coverage Δ
#Integration 55.51% <100%> (-0.02%) :arrow_down:
#Unit 58.99% <100%> (-0.02%) :arrow_down:
Impacted Files Coverage Δ
...Adapter/Core/TestCases/StreamingListTestsParser.cs 95.34% <100%> (-0.11%) :arrow_down:
csoltenborn commented 6 years ago

As a side note: I wanted to push out 0.13.3 this morning, but then found your PR :-) Would you be able to add that single test today? I would then release tomorrow morning (with your fix included)...

frboyer commented 6 years ago

Thanks for your review. Yes, I can do that this morning (EDT time zone).

csoltenborn commented 6 years ago

Awesome, thanks a lot! :-)