search

csoltenborn / GoogleTestAdapter

Visual studio extension that adds support for the C++ testing framework Google Test.
Other
142 stars 101 forks source link

Add support for GTEST_SKIP #260

Closed sixten-hilborn closed 5 years ago

sixten-hilborn commented 5 years ago

Hi,

gtest has a new feature GTEST_SKIP to dynamically skip tests (it's in master but no official release yet): https://github.com/google/googletest/pull/1544 However GTA doesn't recognize this and will report such tests as crashed. Sample test:

TEST(Test, MyTest)
{
    GTEST_SKIP();
}

Gives this output:

Message: 
!! This test has probably CRASHED !!
Test output:

[  SKIPPED ] Test.MyTest (1 ms)
csoltenborn commented 5 years ago

Thanks for the report - should be relatively easy to support...

However, I do not have time at the moment to play around with different gtest versions - would you mind to attach the output of a test executable (i.e., if you run that executable on the command line) containing skipped tests to this issue?

In fact, if you manage to do this today, expect a supporting version at the weekend!

sixten-hilborn commented 5 years ago

That would be great! Here's a small sample and its output attached: test.cpp.txt output.txt

csoltenborn commented 5 years ago

Perfect - stay tuned!