Fixing incorrect logic when reducing to root test suite. Adding flags to allow for not reducing to root test suite.

csoltenborn / GoogleTestAdapter

Visual studio extension that adds support for the C++ testing framework Google Test.

Other

142 stars 102 forks source link

Fixing incorrect logic when reducing to root test suite. Adding flags to allow for not reducing to root test suite. #331

Open EvanHampton-Seequent opened 3 years ago

EvanHampton-Seequent commented 3 years ago

Potentially resolves csoltenborn/GoogleTestAdapter#330. This change fixed the problem I was facing, but it may not necessarily be correct for all cases. Will need to have a conversation about what the correct fix is. Making this PR to get that conversation started, and make the issue I created possibly make more sense.

csoltenborn commented 3 years ago

Hi and thanks for your PR! I currently do not have much time to work on GTA, but I will try to look into this on Sunday...

EvanHampton-Seequent commented 3 years ago

Thanks for getting back to me @csoltenborn - no rush :)