search

csortu / MDAuR

Scripts and data for book: Molecular Data Analysis using R
8 stars 8 forks source link

reproducing figs 5.7 and 5.8 #4

Open seifried opened 7 years ago

seifried commented 7 years ago

Sorry, although the recent script starting at p115 runs without error message, the output does not agree with Figs 5.7 or 5.8. Nor do computed results agree with your text or published plots. Computed results agree with computed plots. I'm wondering if data has changed, or something incorrect in new coded algorithm. The ratiobatch appeared to solve for appropriately labelled data (per your table 5.2). The error plots for each sample have significant discrepancies between differently-calculated efficiencies. This is my version of Fig.5.7

image

Not clear to me if data properly designated/labelled in your new code (I could not decipher). I'm thinking the indexing may have been wrong? FYI, I did not use any of the lines that were commented out. Following is my version of Fig.5.8

myfig5_8

csortu commented 7 years ago

OK, I have to more deeply investigate this one. I have fixed the issue with the legend placement on figure 5.8, but I will need a bit more time with the efficiencies calculated in different ways.

Thanks again for locating this issue!

Csaba