search

csound / csound-vscode-plugin

Plugin for Csound Language support in Visual Studio Code
MIT License
25 stars 8 forks source link

Add ability to play the CSD file in the currently-active editor windo… #3

Closed forrcaho closed 5 years ago

forrcaho commented 5 years ago

…w from within VSCode

I'm taking some of the lessons that I learned implementing the vscode plugin for ChucK and applying them here. This PR implements a command to play the CSD file in the currently active editor window.

I bumped the version number to 0.2.0 since it's adding a feature.

I know this is a big change; please let me know if you have any questions. I can certainly change the coding style more to your liking if there's a way you'd rather organize it.

stekyne commented 5 years ago

That's great stuff, thanks for the contribution. Coding style looks fine to me.

forrcaho commented 5 years ago

I just realized i forgot one of the configuration settings. I'll have another commit for this PR coming shortly -- please hold off on merging until I get that in.

rorywalsh commented 5 years ago

This is really cool Forest. I look forward to trying it out ;)

forrcaho commented 5 years ago

OK, I made that second commit. This should be good to go.

kunstmusik commented 5 years ago

Tested locally and works here. One issue is that if you call the start command multiple times, it will not stop the previous run. Also we need to update Changelog and README.md (and to remove changelog information from the README) and update some other version things. Otherwise, will merge this now and we can update later.

Thanks for this @forrcaho. It's a great step forward and we can build off of this to add live coding facilities.

kunstmusik commented 5 years ago

NM, I think the debug extension mode is throwing me off, I see the changes for Changelog and README.

kunstmusik commented 5 years ago

Version 0.2.0 published to Marketplace, thanks again @forrcaho .

forrcaho commented 5 years ago

One issue is that if you call the start command multiple times, it will not stop the previous run.

That could be construed as a feature.

It does sound like we probably need a way to kill any running processes. I think perhaps Ctrl+C when the focus is on the Csound output window would be intuitive, or maybe esc. I'll see what I can come up with.

rorywalsh commented 5 years ago

I think we definitely need some way of stopping a .csd file too. Or am I missing that? Killing vscode doesn't kill the process.