search

csowada / ebus-configuration

This is the community repository for the configuration file of the eBUS library
Eclipse Public License 1.0
5 stars 7 forks source link

Typo in setter ac.fan_step0 / ac.fan_step1 / ac.fan_step2 / ac.fan_step3 in config file wolf-cwl-configuration.json #17

Open LuiSauberhorn opened 1 year ago

LuiSauberhorn commented 1 year ago

Bug in setter for CWL300/400

Hi @csowada,

I tested your new binding, works well.

However, as you may remember, I was the one sending you the config for the CWL400. In context of changing the binding, I also changed to your config file. In general works fine, but there is one bug/typo.

In https://github.com/csowada/ebus-configuration/blob/master/src/main/resources/commands/wolf-cwl-configuration.json, we have the following code for ac.fan_step0, ac.fan_step1, ac.fan_step2, and ac.fan_step3:

        {   
            "label":    "Fan Step X",
            "id":       "ac.fan_stepX",

            "get": {
                "command": "40 50",
                "master": [
                    {"type": "static", "default": "03"}
                ],
                "slave": [
                    {"name": "fan_stepX", "type": "uint", "label":"Current Value", "reverseByteOrder": true, "format":"%4dm³/h"},   
                    {"name": "min", "type": "uint", "label":"Minimum", "reverseByteOrder": true, "format":"%4dm³/h"},   
                    {"name": "max", "type": "uint", "label":"Maximum", "reverseByteOrder": true, "format":"%4dm³/h"},   
                    {"name": "step", "type": "uint", "label":"Step", "reverseByteOrder": true, "format":"%4dm³/h"},   
                    {"name": "factory_default", "type": "uint", "label":"Factory Default", "reverseByteOrder": true, "format":"%4dm³/h"}
               ]
            },

            "set": {
                "command": "40 80",
                "master": [
                    {"type": "static", "default": "03"},
                    {"name": "cur", "type": "uint", "label":"Current Value", "reverseByteOrder": true, "min": 50, "max": 400, "step": 5, "format":"%4dm³/h"}   
                ]
            }
        },

The setter still uses my old name cur instead of the one you set fan_stepX. By that, I can read but not write. As far as I can see, that only affects the steps.

Lüftungsanlage CWL 400 Excellent

Leave out the rest, as the problem should be obvious. Thanks!