search

csparpa / fluentcheck

Fluent assertions for Python
MIT License
84 stars 8 forks source link

Unit test all assertion methods #1

Open csparpa opened 5 years ago

csparpa commented 5 years ago

Ideally, test coverage of assertion methods (eg. is_none(), is_not_none(), etc.) should be 100%

deanagan commented 4 years ago

Hi @csparpa , I've submitted a pull request for the dicts testing. I will try to get some done on the other ones.

hedyhli commented 4 years ago

Hello, is this issue still available?

I went over the files and found that for Check there is sequences tests missing

deanagan commented 4 years ago

The unit tests are not complete. From the last time I ran it, the code coverage isn't 100%.

deanagan commented 4 years ago

I ran it just now. We are at 94% code coverage.

hedyhli commented 4 years ago

Yeah same for me, I started working on test_sequences for Check in my fork haven't finished yet. I'm not sure if the format is good either, you can check it out if you like. Although the python setup.py test is running ok, I haven’t checked the coverage report after adding test_sequences just yet

csparpa commented 4 years ago

@hedythedev thanks for contributing to fluentcheck! If you're testing the Check assertions, also pls take the chanche also to write the same tests - if missing - for the Is idiom.

hedyhli commented 4 years ago

Got it, I checked a few hours ago that there were tests for sequences for Is, but tests for sequences for Check is missing so i was working on it as I said in the comment above :D