csparpa / pyowm

A Python wrapper around the OpenWeatherMap web API
https://pyowm.readthedocs.io
MIT License
791 stars 175 forks source link

Just wondering if geojson max version restriction is needed? #269

Closed ghost closed 6 years ago

ghost commented 6 years ago

I've got another library using geojson and it wants to update it, but I get a warning as follows:

pyowm 2.9.0 has requirement geojson<2.4,>=2.3.0, but you'll have geojson 2.4.1 which is incompatible.

Just wondering if this restriction is needed?

PS - thanks for this excellent library!

csparpa commented 6 years ago

Hi @lardconcepts you're right: it's not Instead of:

geojson>=2.3.0,<2.4

it should be

geojson>=2.3.0,<3

I'll look into it... for the moment please just uninstall PyOWM and install it again via git cloning the masterbranch, then patching the requirements.txt file yourself (as stated above) and then installing with python setup.py install from within the cloned folder

As usual, thanks for notifying!

csparpa commented 6 years ago

Fix completed on https://github.com/csparpa/pyowm/commit/8329135148ba7164734ad498b53cb05e245557bf