Set use_ssl to True as default

csparpa / pyowm

A Python wrapper around the OpenWeatherMap web API

https://pyowm.readthedocs.io

MIT License

789 stars 171 forks source link

Set use_ssl to True as default #303

Closed edenhaus closed 4 years ago

edenhaus commented 4 years ago

Ciao Claudio,

Nowadays the most traffic already is using https and I think we should activate it as default. We are always sending our api key in our requests. What do you think?

Saluti dall'alto adige

csparpa commented 4 years ago

Ciao,

it seems very reasonable to me :)

Would you please modify that flag in the default configuration and run all tests (unit + integration) just to make sure everything works? In particular, I'd check that the HTTP client library (requests) works as expected

Thank you very much!

PS: I'm literally craving for a trekking session in Alto Adige - it's been 3 years since the last one!!

csparpa commented 4 years ago

Fixed by #305