search

csparpa / pyowm

A Python wrapper around the OpenWeatherMap web API
https://pyowm.readthedocs.io
MIT License
789 stars 171 forks source link

coveralls is not working on develop #304

Closed edenhaus closed 4 years ago

edenhaus commented 4 years ago

Ciao Claudio,

Since the commit 9adfae5941a8bda562def5710c9435614c93c726 the Coveralls is not anymore working and shows a coverage of 0%.

csparpa commented 4 years ago

Ciao!

it looks like we're facing another instance of the "but how is that possible? it's working like a charm on my PC!" non-written principle of software engineering :)

Have you installed the deps specified in https://github.com/csparpa/pyowm/blob/develop/dev-requirements.txt ?

Can you pls post the output of a toxrun ?

Thanks

edenhaus commented 4 years ago

I did not run it locally. I only check it online on the website: https://coveralls.io/github/csparpa/pyowm?branch=develop

csparpa commented 4 years ago

...and back to green with https://github.com/csparpa/pyowm/commit/5284268f280999dfe88a9596c8774f948edb5a33

As you can see from https://coveralls.io/builds/30228842 we have a 96% coverage, not that bad after all