search

csparpa / pyowm

A Python wrapper around the OpenWeatherMap web API
https://pyowm.readthedocs.io
MIT License
789 stars 171 forks source link

pinned and limited PySocks==1.7.1,<2 ??? #334

Closed onkelbeh closed 3 years ago

onkelbeh commented 4 years ago

setup.py:

install_requires=[
        'requests>=2.20.0,<3',
        'geojson>=2.3.0,<3',
        'PySocks==1.7.1,<2',
        'requests[socks]'
    ]

makes no sense. In general, versions should be pinned only with a reason. Thanks a lot.

csparpa commented 3 years ago

Hi @onkelbeh

version had been pinned to avoid major version updates on dependencies breaking PyOWM

Is there something I am missing here? Extra-zeal on my side?

onkelbeh commented 3 years ago

Yep, you already pin PySocks==1.7.1 so the second constraint <2 is already fulfilled.

Found this during compile and constraints tests for Home Assistant Gentoo Overlay. Hope you don't mind I added your component to it. Currently PySocks==1.7.1 is OK, but this will change :-)

csparpa commented 3 years ago

@onkelbeh - Man, I'm happy that PyOWM is useful! :)

Ok so PySocks>=1.7.1,<2 would work OK - am I right ? No more pinning and no major version disruptions

csparpa commented 3 years ago

In the development branch