search

cspeterson / splatmoji

Quickly look up and input emoji and/or emoticons/kaomoji on your GNU/Linux desktop via pop-up menu.
MIT License
212 stars 19 forks source link

Add Nerd Fonts support #18

Open iFreilicht opened 4 years ago

iFreilicht commented 4 years ago

See #17

All Nerd Fonts glyphs were parsed from the official cheat sheet and the .tsv look perfect and works.

I do still have an issue with some glyphs from "Material Design Icons" where some glyphs cause the whole line to be printed in right-to-left order, but that could be an issue with my setup/fonts. If anyone could try this out and see if it works on their system, that would be great :)

img-2020-04-01-151933

cspeterson commented 4 years ago

@iFreilicht I've tagged you in a reply to a related pull request about how it would be best to handle "extra" databases like these

cspeterson commented 4 years ago

Regarding the RTL renderings, I had a feeling that after spot-checking a couple of the entries checks out - the unicode codepoints that you and I are seeing rendered RTL are from scripts like Arabic that are supposed to render RTL.

That is, the glyphs are being overridden with your Nerd Font font, but Rofi still recognizes these are RTL codepoints and goes that way.

I have no idea off the top of my head whether that is something that can be configured away via Rofi's theming or options

iFreilicht commented 4 years ago

Ah, that makes perfect sense! I'll have a look and see whether this can be remedied. I'll reply on the other ticket regarding additional databases. EDIT: I see you already made a new issue for that as well.

iFreilicht commented 4 years ago

@ss1978 let's discuss this in #16 only. It's really confusing if the discussion is spread across multiple threads.

iFreilicht commented 4 years ago

I rebased the PR to the current master and updated it to support the new database format.