search

cspiegel / terps

4 stars 2 forks source link

Scummvm changes to L9 interpreter #12

Open cibersheep opened 2 years ago

cibersheep commented 2 years ago

Is this something we want? https://github.com/scummvm/scummvm/commit/54583f98effa15416c4725f7bae37f054e772f5c

They are changing the way images scale adding a ¿parameter? ¿building option? I don't think those changes are upstreamed, would that be the way rather that adding them here (if wanted)?

cspiegel commented 2 years ago

If these changes are universally good, they ought to be upstreamed. David Kinder's the L9 maintainer, and he's still active, even if L9 rarely gets updated, so it'd be worth seeing if he thinks they're useful upstream.

I really don't know L9 at all, so I can't evaluate whether these changes would be useful in general.

cibersheep commented 2 years ago

I have asked in the main repo.