cspiegel / terps

4 stars 2 forks source link

Alan 2 errors #15

Closed cibersheep closed 2 years ago

cibersheep commented 2 years ago

Alan 2 tested with https://ifdb.org/viewgame?id=f7u68nd9cquz72br I get:

As you enter the twilight zone of Adventures, you stumble and fall to your knees. In front of you, you can vaguely see the outlines of an Adventure that never was.
SYSTEM ERROR: Could not read all ACD code.

From both versions, this one and garglk

cspiegel commented 2 years ago

It fails in garglk and remglk in the same way? Sounds like either a game bug or an interpreter bug, neither of which I'm able to address... I think alan2 is probably unmaintained, but since alan3 is in active development, there may be a developer there who is able to see what's happening.

cibersheep commented 2 years ago

Sorry, my bad: What I meant was that the game fails with the alan2 terp from this repo, and also with the copied alan2 updates from garglk.

The game works on "proper" garglk. Might it be a bug in the building script?

cspiegel commented 2 years ago

Oh, got it.

Right, so I made a typo when I originally added CMake support to Gargoyle. In the Alan2 section, it's supposed to include the macro REVERSED but I'd typed it as RESERVED, which carried through to the repo here. That is probably the source of the problem, as I only fixed it a half year ago. If you're planning on updating the Alan2 sources, you can just fix the macro in that request. Otherwise, I'll make the single change in master.

cibersheep commented 2 years ago

Oh, interesting. Yep, I can do that. I'll update the interpreter from garglk and include the fix