If an instance of pwsh is open in another window, installation fails [Windows]

cspotcode / npm-pwsh

Install PowerShell via npm for use in npm scripts or elsewhere.

12 stars 5 forks source link

If an instance of pwsh is open in another window, installation fails [Windows] #11

Closed fearthecowboy closed 5 years ago

fearthecowboy commented 5 years ago

Installed get-powershell in a local folder, and then ran it.

In another window, tried to install it in another folder, and got:

cspotcode commented 5 years ago

That's troubling; it shouldn't be doing any extraction for the second installation. It should just set up the appropriate symlink / shim script. Maybe there's a logic mistake.

fearthecowboy commented 5 years ago

The assert is failing with the mode check. I sent a PR to correct it on windows

fearthecowboy commented 5 years ago

Confirmed, this is fixed with #12