cspotcode / npm-pwsh

Install PowerShell via npm for use in npm scripts or elsewhere.
12 stars 5 forks source link

Why not call this package 'pwsh' ? #13

Closed fearthecowboy closed 5 years ago

fearthecowboy commented 5 years ago

Before I saw this, I was going to go build the same thing, but I was going to call it pwsh .

I'm still half tempted to push a clone of this to pwsh in npm. 😀

cspotcode commented 5 years ago

This package is the first result when you search for pwsh so I think we're fine.

https://www.npmjs.com/search?q=pwsh

The name get-powershell was chosen because technically it doesn't contain PowerShell; it downloads it seperately. It's a silly distinction, but that's the reason: it behaves a bit differently than most npm packages. Not a strong reason, but meh I don't really care about changing it at this point.

fearthecowboy commented 5 years ago

I just thought of another reason it'd be nice if this was published as pwsh -- done correctly, you'd be able to use npx to run a powershell script. When the package name === the bin name, npx will cache install the package and then run pwsh when done. Doesn't even pollute the PATH.

> npx pwsh get-item --recursive ./  
cspotcode commented 5 years ago

That's a great point. Ok, I'll do it.

On Wed, Oct 24, 2018, 12:32 PM Garrett Serack notifications@github.com wrote:

I just thought of another reason it'd be nice if this was published as pwsh -- done correctly, you'd be able to use npx to run a powershell script. When the package name === the bin name, npx will cache install the package and then run pwsh when done. Doesn't even pollute the PATH.

npx pwsh get-item --recursive ./

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cspotcode/npm-get-powershell/issues/13#issuecomment-432731360, or mute the thread https://github.com/notifications/unsubscribe-auth/AAW-uMzJIQN3uijhm9j8sHQiumqJ1qTyks5uoJYwgaJpZM4W03aG .

fearthecowboy commented 5 years ago

SQUEEEEEE!

💃 🎆 👍 🎆

Plus, a free pony ride! 🏇

cspotcode commented 5 years ago

Done! Thanks for your patience; getting tests running on Travis took way longer than anticipated.