add setter for content type

csquared / arduino-restclient

Arduino RESTful HTTP Request Library

MIT License

205 stars 133 forks source link

Closed ghost closed 9 years ago

llad commented 10 years ago

Cool, useful addition. Thoughts:

Just so this doesn't break people's code, you should leave the default content type of: application/x-www-form-urlencoded.
it seems like the contentTypeSet variable should be killed or leveraged. It looks like @csquared wanted to implement a way of setting content type, but didn't wrap it up. Nesting the code for writing the content type under a statement that says !contenttypeSet is kind of confusing.

csquared commented 9 years ago

about to merge: https://github.com/csquared/arduino-restclient/pull/6 to cover this. what do you guys think?