search

css-modules / css-modules-loader-core

A loader-agnostic CSS Modules implementation, based on PostCSS
91 stars 34 forks source link

update postcss to version 7 #231

Closed EECOLOR closed 2 weeks ago

EECOLOR commented 5 years ago

please note that you need to set the correct version and names for:

The tests are failing. In some case it might be because they reference a local version of the dependency. In others the behavior of the dependency is changed. I lack domain knowledge to determine if the changes are ok.

https://github.com/css-modules/postcss-modules-extract-imports/pull/150 https://github.com/css-modules/postcss-icss-selectors/pull/125 https://github.com/css-modules/postcss-icss-composes/pull/169 https://github.com/css-modules/postcss-icss-values/pull/113

EECOLOR commented 5 years ago

Also adjust travis build. Node 4 is no longer supported: https://github.com/postcss/postcss/releases/tag/7.0.0

lukeed commented 4 years ago

This is so necessary.

This module – on its own – pulls in two distinct versions of postcss: graph

It's directly & solely responsible for postcss@6.0.1 being loaded. It shares responsibility for postcss@6.0.23 with:

Then postcss-modules, a popular dependent of this package, requires postcss@7.0.32 – as it should, since that's the latest.

In any event postcss-modules loads 49 packages total in its network. This css-modules-loader-core package is responsible for 38 of them.

No wonder postcss-modules takes so long to install.

If you don't care about this package anymore, please transfer it to someone who does.

EECOLOR commented 4 years ago

@lukeed Please read these comments:

https://github.com/css-modules/postcss-modules/issues/70#issuecomment-464376447 https://github.com/css-modules/postcss-modules/issues/70#issuecomment-465015687,

lukeed commented 4 years ago

I'm just looking to get things fixed as quickly and simply as possible. I don't think it's wise to hold out/dream for plugin rewrites when something like dependency resolution has been a blocker/unmaintained for ~2 years

EECOLOR commented 4 years ago

That is exactly the reason why we stepped away from using this module and just used the separate underlying modules that do the actual work.

jquense commented 3 years ago

who holds the keys to this package? @alexander-akait do you have access to this? most bundle css-modules support outside of webpack is using this incredibly outdated tool. It deserves love. I would be happy to help update and maintain it if someone who has access could please hand over the keys 🙏 css-modules is too pervasive to be abandonware and i'm happy to help! cc @markdalgleish @geelen

EECOLOR commented 3 years ago

@jquense In hindsight using this specific module proved to cause problems. That is why we now embrace the move to the underlying libraries. If you do want to try and create a package like this, you might find some inspiration here:

https://github.com/kaliberjs/build/blob/master/library/webpack-loaders/css-loader.js https://github.com/kaliberjs/build/blob/master/library/postcss-plugins/postcss-import-export-parser.js

alexander-akait commented 3 years ago

How I can help?