Closed jquense closed 3 years ago
cc @evilebottnawi
sorry for the formatting noise, editor applied my prettier config
i ran it explicitly b/c the lint script is also doing it. It seems like there is a mismatch between which config is used locally though. Is there a standard config ya'll use I can add to the package.json here?
no configuration, we use prettier without options
I think the problem is it's picking up my home directory config. this passes lint for me, but obviously not in CI. might need to have an explicit config. will check
both ideally. I'm going to use this for my stuff, but without css-loader support it requires a custom css-loader to work nicely in webpack. Basically css-module support in Svelte is very hard otherwise.
I understand if that is challenging tho, My guess would be that this is pretty low risk and doesn't expand the complexity in css-loader (i hope)
I understand if that is challenging tho, My guess would be that this is pretty low risk and doesn't expand the complexity in css-loader (i hope)
Yep, I'm only worried about performance here
Yep, I'm only worried about performance here
it should be the same amount of work as before. extracting is only doing a shallow loop through root nodes (which is was doing anyway), so no additional passes, and no more extracting than you'd do otherwise.
@jquense Thanks for the PR, can you ping me tomorrow and we will do merge and release
ping!
gtg?
ok should be good now i think
friendly ping!
I will do release tomorrow
https://github.com/css-modules/icss-utils/releases/tag/v5.1.0 released, I changed atrule
to at-rule
because it is right from CSS spec
Follow up to: https://github.com/webpack-contrib/css-loader/issues/1217#issuecomment-720677917 searches for both by default. This should allow for more flexibility with ICSS being used as an actual interchange format when sandwiched between tooling. E.g. Svelte automatically mangles
:import
and:export
rules during it's style scoping pass (not configurable). At rules should be safer, as tools generally have to leave unknown at-rules alone