cssat / sprout-issues

An issue-only repository for the Sprout data collection platform
https://sproutservices.org
2 stars 1 forks source link

Approved old visit reports will appear incomplete if created before the implementation of a new field #112

Open joemienko opened 4 years ago

joemienko commented 4 years ago

Current behavior

If a visit report was created prior to the addition of a required field, the report will be marked as incomplete in the UI

Desired behavior

As a user viewing a visit report, if an approved report includes all fields that were required as of the day of the approval, then the visit report should not be marked incomplete, so that I see an indication of completeness according to the policy/rules that applied to the report when the report was approved.

joemienko commented 4 years ago

@cssatmcfunk - this is the issue related to the "validation" improvements I mentioned in slack.

joemienko commented 2 years ago

This issue could be partially resolved by a social worker micro visitation app where a new simplified report template would be enabled.

subaykan commented 7 months ago

Adding note here for future reminder to ourselves:

We can do some conditional validation, e.g. on the 'approved' state as we did here for new transport details fields