csscomb / csscomb.js

CSS coding style formatter
http://csscomb.com/
MIT License
3.29k stars 457 forks source link

Node 8 & 4.2/4.3 doesn't seem to work/format #620

Open lhtdesignde opened 4 years ago

lhtdesignde commented 4 years ago

Hi, I just updated to node 8.16.1 from 6.4.0. I'm on csscomb version 4.2. When running it seem to execute but when running it verbose it actually shows that it's not writing the files. It does in fact sort them but not write them to the system.

node 8.16.1 + csscomb 4.2:

Reading app/assets/stylesheets/styles.scss...OK
>> Sorting file "app/assets/stylesheets/styles.scss"...
Done.

When downgrading again to node 6 it starts to work again and tells me: node 6.4.0 + csscomb 4.2:

Reading app/assets/stylesheets/styles.scss...OK
>> Sorting file "app/assets/stylesheets/styles.scss"...
Writing app/assets/stylesheets/styles.scss...OK
Done.

And in fact it formats my files in node version 6 but not in 8. Downgrading to csscomb v3.1 also fixes the issue. node 8.16.1 + csscomb 3.1.8:

Reading app/assets/stylesheets/styles.scss...OK
>> Sorting file "app/assets/stylesheets/styles.scss"...
Writing app/assets/stylesheets/styles.scss...OK
Done.

So not sure why this is, but at least you got a good idea what to be aware of when using more node 8 features.