search

cssinjs / aphrodite-jss

Aphrodite-like API on top of JSS.
MIT License
92 stars 17 forks source link

Specify jss and jss-preset-default as peerDependencies #17

Closed kohlmannj closed 7 years ago

kohlmannj commented 7 years ago

This may or may not be desirable, but here's the idea:

Apart from the maintenance PR I had done last week, I realized that making aphrodite-jss peer-dependent on the current major versions of jss and jss-preset-default may help avoid out-of-date critical dependencies in the future.

kof commented 7 years ago

It will introduce a less user friendly setup, I had the exact same story the other way around in react-jss. I used for a long time peerDependencies and people complained about the need to install jss, preset default etc.

kof commented 7 years ago

So I would rather not do this.

kohlmannj commented 7 years ago

@kof Honestly, good reasons, so happy to close this PR.