search

cssinjs / aphrodite-jss

Aphrodite-like API on top of JSS.
MIT License
92 stars 17 forks source link

Added more tests #23

Open msnider opened 5 years ago

msnider commented 5 years ago

Added a few more tests, particularly around special cases. For Issue #16

kof commented 5 years ago

I would write this function https://github.com/cssinjs/jss/blob/master/packages/jss/tests/utils.js#L59 and use setup the jss instance with it, so that test don't have generated ids, because in case they will change, tests will fail and we will have too many diffs in snapshots for no good reason.

Another point: I would use jest default settings and put integration tests into __tests__ and unit tests into {unit}.test.js

Otherwise looks good.