cssinjs / css-vendor

Runtime vendor prefixing based on feature detection.
MIT License
67 stars 24 forks source link

`transition: var(--something)` gets converted to `false(--something)` #112

Closed brianmhunt closed 5 years ago

brianmhunt commented 5 years ago

In JSS, which uses this plugin:

cls: {
  transition: 'var(--something)'
}

gets converted (via supportedValue) to

.cls-0-1-7 {
  transition: false(--something);
}

Namely, the var is being converted to false.

If I've tracked the stack appropriately, the issue appears to occur here:

prefixedValue = prefixedValue.replace(transPropsRegExp, prefixTransitionCallback)

See downstream issue in the JSS library https://github.com/cssinjs/jss/issues/1099

AleshaOleg commented 5 years ago

https://github.com/cssinjs/css-vendor/pull/113

AleshaOleg commented 5 years ago

Fixed in 2.0.5

brianmhunt commented 5 years ago

Great, thanks @AleshaOleg . Looking forward to it moving downstream to jss.

Please feel free to close this issue.

Cheers

AleshaOleg commented 5 years ago

@brianmhunt https://github.com/cssinjs/jss/pull/1142 here we go. Closing it.