Support values with `!important` keyword, fix cssinjs/jss#565

cssinjs / css-vendor

Runtime vendor prefixing based on feature detection.

MIT License

67 stars 24 forks source link

Support values with `!important` keyword, fix cssinjs/jss#565 #32

Closed andrepolischuk closed 6 years ago

andrepolischuk commented 6 years ago

element.style[property] = value don't apply values with !important. I think we need check/cache values without important and return with it.

kof commented 6 years ago

closing this one, it will be taken care of in the other PR's, please let me know if we forget something.

kof commented 6 years ago

Btw. core now supports !important using array syntax like this: ['red', '!important'], potentially we could introduce a plugin that converts from 'red !important' to array, but considered !important shouldn't be needed at all, I think it is a too rare case to make it into the default preset or core.