search

cssinjs / css-vendor

Runtime vendor prefixing based on feature detection.
MIT License
67 stars 24 forks source link

fix for breaking complex transition values #42

Closed marzelin closed 6 years ago

marzelin commented 6 years ago

why: fixes https://github.com/cssinjs/jss/issues/661

how: transPropsRegExp no longer matches values that are inside parentheses.

kof commented 6 years ago

I have been thinking what to do about this part, ultimately I think we should not touch complex values at all, because we need a full value parser to do it right. It should be only prefixing some simple values.

kof commented 6 years ago

We will be able to prefix fully correctly once we have ISTF in place.

marzelin commented 6 years ago

Full value parser is a great idea. I'm closing this pr then.

Cheers.

kof commented 6 years ago

Well, the problem is that full value parser is way too much for runtime.

kof commented 6 years ago

lets go with your PR for now, until we figure out ISTF