search

cssinjs / jss-loader

JSS Loader for Webpack
MIT License
65 stars 8 forks source link

Add jss dependency #3

Closed joshgillies closed 8 years ago

joshgillies commented 8 years ago

Not sure if there was a reason for excluding it in the first place?

markdalgleish commented 8 years ago

This is deliberate, so that the end user is in control of the JSS version. Otherwise this loader will have to keep updating for no reason, just to stay up to date with JSS.

joshgillies commented 8 years ago

Interesting, I wouldn't say I'm against this decision, but will highlight that it doesn't seem to be a common practice amongst other Webpack loaders.

I guess a point for maintaining the version relative to the loader is to better manage API changes that could take place within JSS?