search

cssinjs / jss

JSS is an authoring tool for CSS which uses JavaScript as a host language.
https://cssinjs.org
MIT License
7.08k stars 399 forks source link

[react-jss]: wrong 'transition' parse #1204

Closed chrisands closed 4 years ago

chrisands commented 5 years ago

Expected behavior: transition: 'ease-in-out 0.3s' parses to transition: ease-in-out 0.3s or

Describe the bug: transition 'ease-in-out 0.3s' parses to transition: false 0.3s ease 0s

Note: If don't use function in createUseStyles than transition: 'ease-in-out 0.3s parses to transition: false 0.3s

Codesandbox link: https://codesandbox.io/s/stoic-hoover-91hdt

Versions (please complete the following information):

I would suggest that this is not react-jss problem, but jss parser.

kof commented 5 years ago

I think we fixed something very similar a while ago in prefixer cc @AleshaOleg

AleshaOleg commented 5 years ago

Just another case for transition/transition-property properties, which is not covered. @chrisands thanks!

Here is PR: https://github.com/cssinjs/css-vendor/pull/169

AleshaOleg commented 5 years ago

Fixed in css-vendor@2.0.7

AleshaOleg commented 5 years ago

@kof https://github.com/cssinjs/jss/pull/1208

kof commented 4 years ago

fixed, gonna be in 10.0.1