cssinjs / jss

JSS is an authoring tool for CSS which uses JavaScript as a host language.
https://cssinjs.org
MIT License
7.08k stars 399 forks source link

Upgrade flow to 0.138.0 #1425

Closed kof closed 4 years ago

kof commented 4 years ago

@TrySound seems like I got after the upgrade of rollup weird flow issues, seems like flow is not seeing the types from import any more, you might already know what that is

Importing a type from an untyped module makes it any and is not safe! Did you mean to add // @flow to the top of jss?
[untyped-type-import]

     1│ // @flow
     2│ /* eslint-disable no-use-before-define */
     3│ import warning from 'tiny-warning'
     4│ import type {Plugin} from 'jss'
     5│
     6│ const isObject = obj => obj && typeof obj === 'object' && !Array.isArray(obj)
     7│ const valueNs = `extendCurrValue${Date.now()}`
TrySound commented 4 years ago

Fixed. Missed this.

kof commented 4 years ago

Omg I would have died trying to fix it lol

On Sun, Nov 15, 2020, 13:48 Bogdan Chadkin notifications@github.com wrote:

Fixed. Missed this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cssinjs/jss/pull/1425#issuecomment-727564742, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAM4WATCOL2HQ6W45X6OPTSP7E3HANCNFSM4TVE7XBQ .

TrySound commented 4 years ago

.flow files were missing