Closed VineethK336 closed 3 years ago
Expected behavior: When we give the css rowGap: 10, jss should have ideally translated it to row-gap: 10px css row-gap
rowGap: 10
row-gap: 10px
Describe the bug: However, it was translated to row-gap: 10 (The unit px is missing)
row-gap: 10
px
Codesandbox link: Here's a simple reproduction of the issue: https://codesandbox.io/s/vigilant-pine-z4ytr?file=/src/App.js
Versions (please complete the following information):
Came here following this issue: https://github.com/mui-org/material-ui/issues/23505
If the fix is to add an entry for row-gap in packages/jss-plugin-default-unit/src/defaultUnits.js, I'd be happy to create a PR as well.
packages/jss-plugin-default-unit/src/defaultUnits.js
Released https://github.com/cssinjs/jss/releases/tag/v10.5.1
kof
commented
3 years ago kof
commented
3 years ago
Expected behavior: When we give the css
rowGap: 10, jss should have ideally translated it torow-gap: 10pxcss row-gapDescribe the bug: However, it was translated to
row-gap: 10(The unitpxis missing)Codesandbox link: Here's a simple reproduction of the issue: https://codesandbox.io/s/vigilant-pine-z4ytr?file=/src/App.js
Versions (please complete the following information):
Came here following this issue: https://github.com/mui-org/material-ui/issues/23505
If the fix is to add an entry for row-gap in
packages/jss-plugin-default-unit/src/defaultUnits.js, I'd be happy to create a PR as well.