cssinjs / jss

JSS is an authoring tool for CSS which uses JavaScript as a host language.
https://cssinjs.org
MIT License
7.07k stars 397 forks source link

Add commit lint to project #1465

Open hosseinmd opened 3 years ago

hosseinmd commented 3 years ago

This could help us to generate version and change log automatically.

Maybe some contributors doesn't write a good commit message, so you could do squash-merge and add your own message.

kof commented 3 years ago

Any good repo examples? What tools are available?

hosseinmd commented 3 years ago

You could see React-navigation

hosseinmd commented 3 years ago

They're using @commitlint/config-conventional https://github.com/conventional-changelog/commitlint#readme

for generate version using standard-version https://github.com/conventional-changelog/standard-version#readme

kof commented 3 years ago

As an idea, maybe we should also ask to provide in the PR a changelog by adding it to the template, so that I don't have to try to sum up every PR in a single message, since asking everyone to squash commits is going to be problematic

I would just copy that text into squash-merge message and that would land in the changelog

hosseinmd commented 3 years ago

Good idea.

kof commented 3 years ago

added this section https://github.com/cssinjs/jss/commit/8638d9923a5d6934c7e2cc0d4d1a2e4a1f02d602

hosseinmd commented 3 years ago

Could you add few checkbox like this