search

cssinjs / jss

JSS is an authoring tool for CSS which uses JavaScript as a host language.
https://cssinjs.org
MIT License
7.08k stars 399 forks source link

Fix react peer dep version corresponding react-dom #1504

Closed behnammodi closed 3 years ago

behnammodi commented 3 years ago

I changed react to >=16.8.6 becuase react-dom is 16.8.6

kof commented 3 years ago

thanks

behnammodi commented 3 years ago

@kof what is your opinion about convert class component to function component in react-jss package?

kof commented 3 years ago

you mean changing the underlying implementation of the HOC to use hooks inside?

behnammodi commented 3 years ago

@kof Yes exactly

behnammodi commented 3 years ago

Also JssProvider

kof commented 3 years ago

That's the plan, we have an issue for that somewhere. There is one thing that a class-based implementation does and hooks doesn't - merging classes when classes are passed to the HOC. We need to add this feature to the hooks interface first and then use it when migrating the HOC.

kof commented 3 years ago

Issue regarding merging the classes https://github.com/cssinjs/jss/issues/1276

kof commented 3 years ago

Couldn't find the issue for using hook inside of HOC, so created one https://github.com/cssinjs/jss/issues/1505

kof commented 3 years ago

Here is a separate issue for mgirating the provider https://github.com/cssinjs/jss/issues/1506

behnammodi commented 3 years ago

Ok

behnammodi commented 3 years ago

Can I create a draft PR? and discuss on it

kof commented 3 years ago

sure

kof commented 3 years ago

released in https://github.com/cssinjs/jss/releases/tag/v10.7.0