cssinjs / jss

JSS is an authoring tool for CSS which uses JavaScript as a host language.
https://cssinjs.org
MIT License
7.08k stars 399 forks source link

Add optional chaining checking for sheet. #1592

Closed lenient closed 2 years ago

lenient commented 2 years ago

This may cause a blank page while navigating.

Corresponding Issue(s):

What Would You Like to Add/Fix?

Todo

Expectations on Changes

Changelog

kof commented 2 years ago

Hi

  1. There must be a reason why you don't have a sheet in some case, so we need to figure out the reason and fix it, what you fixed is a consequence
  2. We need a test that reproduces the problem. Without a test I won't be able to merge
lenient commented 2 years ago

Hi @kof , This happens when using micro-frontend, I don't have a standalone example to reproduce it. But this happens on my local env, and ?. is the way to fix it.

kof commented 2 years ago

You need to remove one dependency after another until its just jss

kof commented 2 years ago

please reopen once you have time