search

cssinjs / jss

JSS is an authoring tool for CSS which uses JavaScript as a host language.
https://cssinjs.org
MIT License
7.08k stars 399 forks source link

Line 23 grammar mistake #1633

Closed bubliman closed 2 years ago

bubliman commented 2 years ago

Old:

  1. Does JSS has overhead?

    New:

  2. Does JSS have overhead?

    Why?

    When the subject of a sentence is a third person (he, she, it) we need to follow the rules of Subject-Verb Agreement. Basically add an s to the end of the verb, but when the verb "do" is used it has priority over the other verb so it always matches the subject. In this case the verb "have" has also been matched by mistake.

Corresponding Issue(s):

What Would You Like to Add/Fix?

Todo

Expectations on Changes

Changelog

kof commented 2 years ago

thanks

bubliman commented 2 years ago

@kof I'm new to GitHub, tbh I really like to fix grammar mistakes. Was wondering, if I should provide an explanation like I did now or just fix the mistake?

kof commented 2 years ago

it depends, if you want to be sure people understand why the change is happening, then yes - provide an explanation. if people don't understand the fix they won't merge it or will close it potentially