cssinjs / jss

JSS is an authoring tool for CSS which uses JavaScript as a host language.
https://cssinjs.org
MIT License
7.08k stars 399 forks source link

setup({ id: { minify: true } }) doesn't work with jss-preset-default #1660

Closed baptistecs closed 3 months ago

baptistecs commented 3 months ago

Expected behavior:

image

Describe the bug:

jss-preset-default options + { id: { minify: true } } doesn't minify selector names: image

Reproduction:

https://codesandbox.io/p/sandbox/jss-minify-8w76d4?file=%2Fsrc%2Findex.mjs

Versions (please complete the following information):

Managing expectations:

Maintainers will not be fixing the problem you have unless they have it too, if you want it to get fixed:

  1. Submit a PR with a failing test
  2. Discuss a solution
  3. Implement it

You can also do the first step only and wait for someone else to work on a fix. Anything is much better than nothing.

baptistecs commented 3 months ago

Sorry it works fine when we replace jss.setup(preset()) by jss.setup(options) 🤦‍♂️