Closed brianmhunt closed 6 years ago
Here it says that observables need the Sheet option link: true
.
Also the options for a Sheet a declared here: https://github.com/cssinjs/jss/blob/master/docs/js-api.md#create-style-sheet
But I think we could add an example with how to use observables.
Thanks @HenriBeck ; the ambiguity is whether the Sheet
option is on the attach or the create call.
I don't get it, how did you come to think .attach() accepts an options argument? Please send a PR where you think its not clear.
@kof Trivial fix that would've saved 10-15 minutes of wandering around the docs is #739
yeah, I guess docs will never be perfect, thats one every one needs to send fixes like this one :)
The JSS docs on observables mentions that one needs to use
link: true
, but does not mention where.For example, given:
It's not clear which of the following is correct:
Seems like it's neither; rather, if you trace
.attach
, it looks like it usesthis.options.link
, but the expectedjss.options
is undefined.All to say, there's a gap that needs to be filled about where
link: true
goes.