cssinjs / jss

JSS is an authoring tool for CSS which uses JavaScript as a host language.
https://cssinjs.org
MIT License
7.07k stars 399 forks source link

[jss-template] plugin is built as 'jssNested' library #829

Closed G-Rath closed 5 years ago

G-Rath commented 6 years ago

I was adding jss-* plugins to my webpack.cdn.js (webpack config that uses WebpackCdnPlugin, and is just merged into other webpack configs), when I noticed that both jss-template & jss-nested export themselves globally as jssNested.

It seems that jss-template is configured to output as jssNested.

I'm guessing that's not intentional, as I can't find a documented reason (or otherwise that might tie jss-template & jss-nested together).

kof commented 6 years ago

Its a bug

On Tue, Aug 21, 2018, 05:34 Gareth Jones notifications@github.com wrote:

I was adding jss-* plugins to my webpack.cdn.js (webpack config that uses WebpackCdnPlugin, and is just merged into other webpack configs), when I noticed that both jss-template & jss-nested export themselves globally as jssNested.

It seems that jss-template is configured to output as jssNested https://github.com/cssinjs/jss-template/blob/master/webpack.config.js#L21 .

I'm guessing that's not intentional, as I can't find a documented reason (or otherwise that might tie jss-template & jss-nested together).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cssinjs/jss/issues/829, or mute the thread https://github.com/notifications/unsubscribe-auth/AADOWLFlaG2qKE_bp9lkzmA1u8xlQOfmks5uS3-zgaJpZM4WFDEx .

HenriBeck commented 6 years ago

This will be fixed once jss@10 is released. @kof should we release a fix for the old versions?

kof commented 6 years ago

yeah

HenriBeck commented 5 years ago

Closing as this was fixed.