search

cssinjs / styled-jss

Styled Components on top of JSS.
http://cssinjs.org/styled-jss
MIT License
217 stars 25 forks source link

Fix peerDependencies #13

Closed lttb closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 90.476% when pulling f97acac0ef70296f357c658a14a6ecbc3095a8af on feature/fix-peer-deps into ec9518160960f451df9f6982aa862fe5a889b5a1 on master.

kof commented 7 years ago

Why older react version and why no react-dom?

lttb commented 7 years ago

older because people have warnings with older versions, but we require version just from '15.3.0'.

react-dom is a peer dependency of is-react-prop, but not of our package

kof commented 7 years ago

right, then we might go even older

kof commented 7 years ago

if there are no compatibility issues

lttb commented 7 years ago

not now because of PureComponent: https://github.com/facebook/react/blob/master/CHANGELOG.md#1530-july-29-2016

according to my local checks PureComponent was a little bit faster on re-render, but we need to explore this deeper of course