Implement currying interface, resolve #18

cssinjs / styled-jss

Styled Components on top of JSS.

http://cssinjs.org/styled-jss

MIT License

217 stars 25 forks source link

Implement currying interface, resolve #18 #19

Closed lttb closed 7 years ago

lttb commented 7 years ago

BREAKING CHANGE: keep just only curried interface

kof commented 7 years ago

The question is, should we possible have just one interface?

kof commented 7 years ago

It would make the lib code simpler and users code more unified, less confusion.

kof commented 7 years ago

I did the exact same thing for react-jss some time ago.

lttb commented 7 years ago

It would make the lib code simpler and users code more unified, less confusion.

I agree, looks like it's better to make this breaking change now

lttb commented 7 years ago

And I can't get real pros for the previous API

kof commented 7 years ago

btw. don't forget to add changelog with breaking change notice and release a new major verison

coveralls commented 7 years ago

Coverage increased (+0.3%) to 92.857% when pulling 531c927e350c8c9796eac5533e40420bb47c69f0 on feature/curry into e80e66a141bdc71b077f19591ec68f4c3538b5c8 on master.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 92.708% when pulling dbfdaa3cc9991ffc78a09c9009bfeff2aa3f191d on feature/curry into e80e66a141bdc71b077f19591ec68f4c3538b5c8 on master.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 92.708% when pulling 972437075b641c8f4344cfee762657fad7067dd5 on feature/curry into e80e66a141bdc71b077f19591ec68f4c3538b5c8 on master.