search

cssinjs / styled-jss

Styled Components on top of JSS.
http://cssinjs.org/styled-jss
MIT License
217 stars 25 forks source link

Integrate ThemeProvider #20

Closed kof closed 6 years ago

kof commented 7 years ago

@iamstarkov has been working on a unified styling solution https://github.com/iamstarkov/theming and styled-jss needs to integrate it

Main issue https://github.com/cssinjs/jss/issues/488

iamstarkov commented 7 years ago

I need feedback, pls take a look https://github.com/iamstarkov/theming/pull/2

iamstarkov commented 7 years ago

@lttb, react-jss got a theming support in latest release. lemme know if you need any help to fix this issue

kserjey commented 6 years ago

Hi @lttb, how it goes?

lttb commented 6 years ago

hi @kserjey, it's already almost done, planning to integrate it this week https://github.com/cssinjs/styled-jss/pull/35 (just need to upgrade theming version with React 16 support)

ndelangen commented 6 years ago

This would certainly help, this is a pretty important step to get this package more usable in my humble opinion.

Thanks, awesome work!

Pentiado commented 6 years ago

Is there a way to use a theme with Base Stylesheet (https://github.com/cssinjs/styled-jss/blob/master/README.md#base-style-sheet) or it isn't supported yet? I would expect something like this to work:

Styled((theme) => ({
  header: {
    margin: 10,
    color: theme.colorHeader,
  },
}));

I'm using styled-jss in two projects and soon in a third one so if it's not supported I might try to contribute and make it work.