cssinjs / styled-jss

Styled Components on top of JSS.
http://cssinjs.org/styled-jss
MIT License
217 stars 25 forks source link

Fixed issue for dynamic props update #28

Closed wellguimaraes closed 7 years ago

wellguimaraes commented 7 years ago
{
  color: props => props.active ? 'red' : 'black',

  // it was crashing by having this conditional rule here
  '@media screen': {
    background: props => props.active ? 'white' : 'gray'
  }
}
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling fb8cd97b3baa1c7e4447594b42df5ede1c7309e8 on wellguimaraes:master into d3a578a1b0efc2cc9abd43d397f44f90ab3b5abd on cssinjs:master.

lttb commented 7 years ago

There are also some issues with codestyle. That's strange that pre-commit linting dit not work 🤔

Anyway I'll setup linting by CI too

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 12601ea3d37a395e6b1a756893d9610f67887fca on wellguimaraes:master into f35db97e7a1e7310e7701ec64b23dbf6e5d95748 on cssinjs:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8bc484b62f4fb47e71b1880f3966a5caabd0e68f on wellguimaraes:master into f35db97e7a1e7310e7701ec64b23dbf6e5d95748 on cssinjs:master.

lttb commented 7 years ago

@wellguimaraes please rebase your branch by origin, I've fixed Travis config and eslint checks

lttb commented 7 years ago

@wellguimaraes It looks like it still does not work for me (with whole sheet update too)

https://codesandbox.io/s/lYL3Jz3l7

lttb commented 7 years ago

There is an issue w/ jss: https://github.com/cssinjs/jss/issues/511

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d03282ce7e1bd127e853f7baa58d71af06791716 on wellguimaraes:master into 084d92a88731cfca730dca74c7798345db7ec2bf on cssinjs:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 829864b1ab0cfe981f0f2726b206f4689d2425fa on wellguimaraes:master into 084d92a88731cfca730dca74c7798345db7ec2bf on cssinjs:master.

lttb commented 7 years ago

@wellguimaraes it looks like we have fix it, is it okay now?

it works here: https://codesandbox.io/s/M8o5p00rP

wellguimaraes commented 7 years ago

awesome!