cssinjs / theming

Unified CSSinJS theming solution for React
300 stars 39 forks source link

Remaining tasks #1

Closed kof closed 7 years ago

kof commented 7 years ago

Main issue https://github.com/cssinjs/jss/issues/488

iamstarkov commented 7 years ago
iamstarkov commented 7 years ago

fyi, tests are finished

iamstarkov commented 7 years ago

Playground is the only thing which left. Though, i couldnt get online tools like https://www.webpackbin.com/ or https://codesandbox.io/ to work for me. Both of it couldnt handle node_modules.

iamstarkov commented 7 years ago

can anybody try as well?

GertSallaerts commented 7 years ago

Not sure about what you are trying to achieve with regards to a playground. Simply building an example with webpackbin worked for me though: https://www.webpackbin.com/bins/-KlVZN9q82l11_bxHdjQ

If there is anything I can help with, please let me know. I'm eagerly awaiting the release of this package.

iamstarkov commented 7 years ago

@Gertt, its good. can you add PureComponent to demo that it works through it?

GertSallaerts commented 7 years ago

Something like this? If you want, I can try turning it into something prettier. Might be nice if you plan to use it as a preview/demo page.

https://www.webpackbin.com/bins/-KlVZN9q82l11_bxHdjQ

iamstarkov commented 7 years ago

@Gertt that would be nice

GertSallaerts commented 7 years ago

Not a designer obviously, but this does give a more visual representation:

https://www.webpackbin.com/bins/-KlsWD4r_aPN8w42LvoT

iamstarkov commented 7 years ago

@Gertt its good

iamstarkov commented 7 years ago

@Gertt i made few improvements https://www.webpackbin.com/bins/-Km8TglfWP84oYhDquT1

do you like it?

GertSallaerts commented 7 years ago

Looks good to me! Excited to see things moving along

iamstarkov commented 7 years ago

theming