Closed kentcdodds closed 7 years ago
right now withTheme
will throw error if its used without ThemeProvider
https://github.com/iamstarkov/theming/blob/master/src/create-with-theme.js#L22
Ah, in that case, I'd like a way to opt out of that :)
you might want to take a look at themeListener in #3, because it's exactly about that level of deep integration.
pls take a look into that, there is also published theming package in my npm scope with that pr published
That looks like it'll work :+1: Thanks!
This is what we do in glamorous
I'd also love it if this could be disabled. For
GlamorousComponents
, they all need to be themeable, but not always will they be inside a ThemeProvider (you can pass the theme/override via props). So inglamorous
we also accept options:withTheme(Comp, {noWarn: true})
.