docs, tests and implementation review

[iamstarkov]

hey, @kof, @mxstbr, @nathanmarks, @kentcdodds.

I extracted theming from styled-components into separate package, wrote extensive documentation, covered every line and every case with tests. I also thought, that some solutions might need to use custom channel, so i added that as well.

So you might be interested in it

[coveralls]

Changes Unknown when pulling af0faaa080d263595b74cdb9399b19e7f22a6535 on dev-review into on master.

[mxstbr]

I don't think the withTheme HoC is enough for us, there needs to be some way of injecting the context stuff into an existing component. We don't want to wrap every styled-component in another component I don't think?

[iamstarkov]

@mxstbr thats the feature i wanted to, because i want the same in jss as well. Any suggestions on API design and name for this feature?

[iamstarkov]

@mxstbr what about current code, tests and docs?

[iamstarkov]

@mxstbr as far as this feature request we all want to make low level integration easier, i made another pull-request #3, please take a look.

[iamstarkov]

btw, @kof, @nathanmarks, @kentcdodds, i want you to review #3 as well =)

[kentcdodds]

cc @vesparny

[coveralls]

Changes Unknown when pulling 268a88db8dd9e5ac7e8fa307bf1bee82afb9d609 on dev-review into on master.

[coveralls]

Changes Unknown when pulling 268a88db8dd9e5ac7e8fa307bf1bee82afb9d609 on dev-review into on master.

[coveralls]

Changes Unknown when pulling 0198e9a4223c3d9c387a0b2254ca5400da4c6f17 on dev-review into on master.

[coveralls]

Changes Unknown when pulling 1a3e02740cbd6ddcd5bb2f0ce4112204baf3974e on dev-review into on master.

[iamstarkov]

status update:

• under the hood implementation has been rewritten to adhere to best practices described by @vesparny
• docs are the same
• tests are the same, but has to be justified to new implementation; changes are mainly in ./src/test-helpers
• added a feature to withTheme to include component's name into displayName: WithTheme(Button)

@kof, @mxstbr, @nathanmarks, @kentcdodds, @vesparny please review it again

regarding is-function and is-plain-object lets have separate discussions

if this is okay by you, let's merge this into master.

in the mean time i will work on #3

[kof]

LGTM

[iamstarkov]

@mxstbr, its your turn now =)

[iamstarkov]

—what is the time? —release time!

[iamstarkov]

good news @kof, @mxstbr, @philpl, @kentcdodds, @vesparny. y'all are added as collaborators in this project.

One thing about contributing: let's have pull-requests instead of pushing commits straight to the master

[iamstarkov]

theming@1.0.0 just has been published