Closed iamstarkov closed 7 years ago
I don't think the withTheme
HoC is enough for us, there needs to be some way of injecting the context stuff into an existing component. We don't want to wrap every styled-component in another component I don't think?
@mxstbr thats the feature i wanted to, because i want the same in jss as well. Any suggestions on API design and name for this feature?
@mxstbr what about current code, tests and docs?
@mxstbr as far as this feature request we all want to make low level integration easier, i made another pull-request #3, please take a look.
btw, @kof, @nathanmarks, @kentcdodds, i want you to review #3 as well =)
cc @vesparny
status update:
./src/test-helpers
WithTheme(Button)
@kof, @mxstbr, @nathanmarks, @kentcdodds, @vesparny please review it again
regarding is-function
and is-plain-object
lets have separate discussions
if this is okay by you, let's merge this into master.
in the mean time i will work on #3
LGTM
@mxstbr, its your turn now =)
—what is the time? —release time!
good news @kof, @mxstbr, @philpl, @kentcdodds, @vesparny. y'all are added as collaborators in this project.
One thing about contributing: let's have pull-requests instead of pushing commits straight to the master
theming@1.0.0 just has been published
hey, @kof, @mxstbr, @nathanmarks, @kentcdodds.
I extracted theming from styled-components into separate package, wrote extensive documentation, covered every line and every case with tests. I also thought, that some solutions might need to use custom channel, so i added that as well.
So you might be interested in it