cssinjs / theming

Unified CSSinJS theming solution for React
300 stars 39 forks source link

Move react to peerDependencies #27

Closed jgoux closed 6 years ago

jgoux commented 7 years ago

Hi,

Trying the new beta of react 16 broke my project because theming has react as a dependency. (then 2 versions of react are installed)

Moving it to peerDependencies solves the issue.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.8%) to 92.771% when pulling c89db104d83d5d115a2c6bebe499fc9f2245508f on jgoux:patch-1 into ded45451c856ecd05ed4fc2cf4f6044bd916c323 on iamstarkov:master.

marcelofpalves commented 7 years ago

@jgoux did you add back react to devDependencies?