search

cssinjs / theming

Unified CSSinJS theming solution for React
300 stars 39 forks source link

fix: WithTheme HOC should hoist non-react static properties #33

Closed quantizor closed 5 years ago

quantizor commented 6 years ago

This allows the various features of styling libraries that rely on static property tagging to work when wrapped with the withTheme HOC.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 93.805% when pulling ba16fa1680c171fa6c8812de4499fb4aa55b8e7e on probablyup:es-hoist-statics into ded45451c856ecd05ed4fc2cf4f6044bd916c323 on iamstarkov:master.

quantizor commented 6 years ago

@iamstarkov could you take a look at this? Blocking some work I'm trying to complete.

Thank you!

quantizor commented 6 years ago

@iamstarkov /bump

tkh44 commented 6 years ago

I think @kentcdodds needs this as well in order for glamorous to work.

kentcdodds commented 6 years ago

Yes, I would definitely need this :+1: Thanks!

HenriBeck commented 5 years ago

Implemented in #54. Will be released soon