search

cssinjs / theming

Unified CSSinJS theming solution for React
300 stars 39 forks source link

chore: move react + prop-types to peerDeps #34

Closed quantizor closed 6 years ago

quantizor commented 6 years ago

Also loosened the versioning to make future updates easier.

quantizor commented 6 years ago

As a side effect, this should help fix tools like https://cost-of-modules.herokuapp.com/ reporting theming being larger than it really is 😄

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.8%) to 92.771% when pulling 858a99a70e392cbafb8741896b8576b95e0e0f70 on probablyup:es-react-peer into ded45451c856ecd05ed4fc2cf4f6044bd916c323 on iamstarkov:master.

quantizor commented 6 years ago

Not sure why the coverage dropped - no code changes 🤷🏼‍♂️

jgoux commented 6 years ago

I hope this PR will be merged soon. This is blocking my upgrade to React 16, because react-jss depends on this library. :(

kitten commented 6 years ago

@jgoux FYI in the meantime you can add aliases for React and prop-types to Webpack to point to their node_modules folder directly. That’ll replace the npm resolution with the one fixed version you are pointing to

jgoux commented 6 years ago

@philpl Didn't even think about it! Thanks for the tip, it will do for now. ✨

kof commented 6 years ago

we need to update to v16