Update brcast to ^3.0.1

cssinjs / theming

Unified CSSinJS theming solution for React

300 stars 39 forks source link

Update brcast to ^3.0.1 #38

Closed darkowic closed 6 years ago

darkowic commented 6 years ago

BREAKING CHANGE: themeListener.subscribe returns subscriptionId intead of function. To unsubscribe you have to call themeListener.unsubscribe(subscriptionId)

Resolves #36

darkowic commented 6 years ago

@oliviertassinari Can you check this?

oliviertassinari commented 6 years ago

@darkowic I have been reducing the dependency on react-jss. By directly importing required modules, I would expect theming to no longer be required. (https://github.com/callemall/material-ui/pull/8121)

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 92.92% when pulling 2925fb3f9289765e76703a33c093d4a125975489 on darkowic:master into ded45451c856ecd05ed4fc2cf4f6044bd916c323 on iamstarkov:master.

kof commented 6 years ago

@darkowic I know its a long due, can you please clean up the pr, separate the commits or even better send separate PRs?