Added unsubscribe to the theme listener

cssinjs / theming

Unified CSSinJS theming solution for React

300 stars 39 forks source link

Closed TriPSs closed 6 years ago

TriPSs commented 6 years ago

Added the unsubscribe function so we can unsubscribe from the theme-listener in react-jss

This PR goes together with react-jss - 187

kof commented 6 years ago

thanks!

kof commented 6 years ago

Damn, just realized, subscribe function returns an unsubscribe function, there is no need in separate unsubscribe function. Why??????

TriPSs commented 6 years ago

Because I logged it and the only thing I got back was an ID

kof commented 6 years ago

Wow, true, turns out brcast library has changed!

kof commented 6 years ago

And the reason was a performance optimization.